[GitHub] [hbase] saintstack commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

[GitBox]

saintstack commented on a change in pull request #2800:
URL: https://github.com/apache/hbase/pull/2800#discussion_r552821049



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -308,7 +294,7 @@ protected HStore(final HRegion region, final 
ColumnFamilyDescriptor family,
       this.compactionCheckMultiplier = 
DEFAULT_COMPACTCHECKER_INTERVAL_MULTIPLIER;
     }
 
-    this.storeEngine = createStoreEngine(this, this.conf, this.comparator);
+    this.storeEngine = createStoreEngine(this, this.conf, getComparator());

Review comment:
       ditto

##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -268,34 +251,37 @@ protected HStore(final HRegion region, final 
ColumnFamilyDescriptor family,
       .addBytesMap(region.getTableDescriptor().getValues())
       .addStringMap(family.getConfiguration())
       .addBytesMap(family.getValues());
-    this.blocksize = family.getBlocksize();
+
+    this.region = region;
+    this.storeContext = initializeStoreContext(family);
+
+    // Assemble the store's home directory and Ensure it exists.
+    getRegionFileSystem().createStoreDir(family.getNameAsString());
 
     // set block storage policy for store directory
     String policyName = family.getStoragePolicy();
     if (null == policyName) {
       policyName = this.conf.get(BLOCK_STORAGE_POLICY_KEY, 
DEFAULT_BLOCK_STORAGE_POLICY);
     }
-    this.fs.setStoragePolicy(family.getNameAsString(), policyName.trim());
+    getRegionFileSystem().setStoragePolicy(getColumnFamilyName(), 
policyName.trim());

Review comment:
       You were going to change these back?

##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
##########
@@ -46,6 +46,8 @@
   int PRIORITY_USER = 1;
   int NO_PRIORITY = Integer.MIN_VALUE;
 
+  int getBlockSize();

Review comment:
       Is this necessary? Its available on the ColumnFamilyDescriptor. Do we 
need to add new method on Store?
   
   Was this change always here or did it just show up in recent amendments to 
PRs (I don't remember seeing it before but probably just me).
   
   Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org