dasanjan1296 commented on a change in pull request #2855:
URL: https://github.com/apache/hbase/pull/2855#discussion_r554285615
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java
##########
@@ -131,14 +131,14 @@ public void testWALArchiveWithDifferentWalAndRootFS()
throws Exception{
}
executor.submitProcedure(splitProcedure);
LOG.info("Submitted SplitProcedure.");
- test_util_2.waitFor(30000, () -> executor.getProcedures().stream()
- .filter(p -> p instanceof TransitRegionStateProcedure)
- .map(p -> (TransitRegionStateProcedure) p)
- .anyMatch(p -> TABLE_NAME.equals(p.getTableName())));
- test_util_2.getMiniHBaseCluster().killRegionServer(
- test_util_2.getMiniHBaseCluster().getRegionServer(0).getServerName());
- test_util_2.getMiniHBaseCluster().startRegionServer();
- test_util_2.waitUntilNoRegionsInTransition();
+ testUtil2.waitFor(30000, () -> executor.getProcedures().stream()
+ .filter(p -> p instanceof SplitTableRegionProcedure)
+ .map(p -> (SplitTableRegionProcedure) p)
+ .anyMatch(p -> TABLE_NAME.equals(p.getTableName())) &&
splitProcedure.isSuccess());
+ testUtil2.getMiniHBaseCluster().killRegionServer(
+ testUtil2.getMiniHBaseCluster().getRegionServer(0).getServerName());
+ testUtil2.getMiniHBaseCluster().startRegionServer();
+ testUtil2.waitUntilNoRegionsInTransition();
Review comment:
Yes, I agree with you. Simply doing a split wal operation should be
enough to test this particular scenario. I went overboard with the test while
trying to explore a few things. I've updated the test per your suggestion.
PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
