[
https://issues.apache.org/jira/browse/HBASE-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274562#comment-13274562
]
Hadoop QA commented on HBASE-5998:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526736/5998.v3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 31 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.TestDrainingServer
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1865//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1865//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1865//console
This message is automatically generated.
> Bulk assignment: regionserver optimization by using a temporary cache for
> table descriptors when receveing an open regions request
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5998
> URL: https://issues.apache.org/jira/browse/HBASE-5998
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5998.v2.patch, 5998.v3.patch
>
>
> During the assignment, on the regionserver, before creating the handlers we
> load the table description. Even if there is a cache, we check the timestamps
> for each region, while it's not necessary. The test below is just with one
> node, with more nodes the benefit will improve. By limiting the time spent in
> HRegion#openRegion we increase the parallelization during cluster startup, as
> the master is using a pool of threads to call the RS.
> -- Without the fix
> 2012-05-14 11:40:52,501 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 1193
> region(s) to localhost,11003,1336988444043
> 2012-05-14 11:41:09,947 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning done for
> localhost,11003,1336988444043
> -- With the fix
> 2012-05-14 11:34:40,444 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 1193
> region(s) to localhost,11003,1336988444043
> 2012-05-14 11:34:40,929 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning done for
> localhost,11003,1336988065948
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
