caroliney14 commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-758870917
@Apache9 I don't think I follow, can you clarify what you meant: > maybe we could have another map in ServerManager to record the region servers which have called regionServerStartup but no regionServerReport yet, and once there is a regionServerReport, we move it the actual active region server map and allow it to take regions. Why do we need another map? Isn't it enough that the server be marked as online upon its first `regionServerReport()`? Or are we trying to catch some error where a rs may have called `regionServerStartup()` but not `regionServerReport()`? > If we do not register our znode on zookeeper after calling regionServerStartup No need to worry about this I think, since I am not changing this logic. We are registering the znode in `handleReportForDutyResponse()` which occurs right after `regionServerStartup()`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
