virajjasani commented on a change in pull request #2866:
URL: https://github.com/apache/hbase/pull/2866#discussion_r557059396
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpoint.java
##########
@@ -122,7 +125,7 @@ public static void afterClass() throws Exception {
}
@Test
- public void testRegionReplicaReplicationPeerIsCreated() throws IOException {
+ public void testRegionReplicaReplicationPeerIsCreated() throws IOException,
InterruptedException {
Review comment:
I think now we don't need this, IOException alone is enough?
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpoint.java
##########
@@ -487,4 +490,26 @@ private void testRegionReplicaReplicationIgnores(boolean
dropTable, boolean disa
connection.close();
}
}
+
+ private void createOrEnableTableWithRetries(TableDescriptor htd, boolean
createTableOperation) {
+ // Helper function to run create/enable table operations with a retry
feature
+ boolean continueToRetry = true;
+ int tries = 0;
+ while (continueToRetry && tries < 100) {
Review comment:
Although we don't expect `ReplicationException` to keep showing up till
100s, but 100s is huge duration that we are waiting on here. It will make tests
timeout if we have some issue. Let's keep this 50 maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
