Apache9 commented on a change in pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#discussion_r560043688
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
##########
@@ -354,7 +320,27 @@ protected boolean initialChore() {
/**
* Override to run cleanup tasks when the Chore encounters an error and must
stop running
*/
- protected synchronized void cleanup() {
+ protected void cleanup() {
+ }
+
+ /**
+ * Call {@link #shutdown(boolean)} with {@code true}.
+ * @see ScheduledChore#shutdown(boolean)
+ */
+ public synchronized void shutdown() {
+ cancel(false);
+ cleanup();
Review comment:
Oh, a typo. It should be `shutdown(true);`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
