huaxiangsun commented on a change in pull request #2868:
URL: https://github.com/apache/hbase/pull/2868#discussion_r560423945
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java
##########
@@ -99,6 +99,25 @@ public void testSplitFlushCompactUnknownTable() throws
InterruptedException {
assertTrue(exception instanceof TableNotFoundException);
}
+ @Test
+ public void testCompactATableWithSuperLongTableName() throws Exception {
+ TableName tableName = TableName.valueOf(name.getMethodName());
+ TableDescriptor htd = TableDescriptorBuilder.newBuilder(tableName)
+ .setColumnFamily(ColumnFamilyDescriptorBuilder.of("fam1")).build();
+ try {
+ ADMIN.createTable(htd);
+ try {
+ ADMIN.majorCompactRegion(tableName.getName());
+ ADMIN.majorCompactRegion(Bytes.toBytes("abcd"));
Review comment:
Done
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java
##########
@@ -299,7 +299,8 @@ public void testCloseRegionIfInvalidRegionNameIsPassed()
throws Exception {
if (regionInfo.getRegionNameAsString().contains(name)) {
info = regionInfo;
try {
- ADMIN.unassign(Bytes.toBytes("sample"), true);
+ ADMIN.unassign(Bytes.toBytes(
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
