sunhelly commented on a change in pull request #2889:
URL: https://github.com/apache/hbase/pull/2889#discussion_r562014142
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##########
@@ -921,8 +921,10 @@ public boolean isClusterShutdown() {
public void startChore() {
Configuration c = master.getConfiguration();
if (persistFlushedSequenceId) {
- // when reach here, RegionStates should loaded, firstly, we call remove
deleted regions
- removeDeletedRegionFromLoadedFlushedSequenceIds();
+ new Thread(() -> {
+ // when reach here, RegionStates should loaded, firstly, we call
remove deleted regions
+ removeDeletedRegionFromLoadedFlushedSequenceIds();
+ }, "RemoveDeletedRegionSyncThread").start();
Review comment:
Should this be a demon thread?
And seems that removeDeletedRegionFromLoadedFlushedSequenceIds could be a
part of FlushedSequenceIdFlusher?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
