ZhaoBQ commented on a change in pull request #2917:
URL: https://github.com/apache/hbase/pull/2917#discussion_r570023884
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##########
@@ -468,12 +467,13 @@ private static boolean isOldEnoughForMerge(
*/
private boolean isLargeEnoughForMerge(
final NormalizerConfiguration normalizerConfiguration,
+ final NormalizeContext ctx,
final RegionInfo regionInfo
) {
- return getRegionSizeMB(regionInfo) >=
normalizerConfiguration.getMergeMinRegionSizeMb();
+ return getRegionSizeMB(regionInfo) >=
normalizerConfiguration.getMergeMinRegionSizeMb(ctx);
}
- private static boolean logTraceReason(final BooleanSupplier predicate, final
String fmtWhenTrue,
+ private boolean logTraceReason(final BooleanSupplier predicate, final String
fmtWhenTrue,
Review comment:
I find skipForSplit, logTraceReason, isOldEnoughForMerge is static, but
it does not need static. I am not sure what is the purpose of setting those to
static.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##########
@@ -468,12 +467,13 @@ private static boolean isOldEnoughForMerge(
*/
private boolean isLargeEnoughForMerge(
final NormalizerConfiguration normalizerConfiguration,
+ final NormalizeContext ctx,
final RegionInfo regionInfo
) {
- return getRegionSizeMB(regionInfo) >=
normalizerConfiguration.getMergeMinRegionSizeMb();
+ return getRegionSizeMB(regionInfo) >=
normalizerConfiguration.getMergeMinRegionSizeMb(ctx);
}
- private static boolean logTraceReason(final BooleanSupplier predicate, final
String fmtWhenTrue,
+ private boolean logTraceReason(final BooleanSupplier predicate, final String
fmtWhenTrue,
Review comment:
Thanks for the wonderful answers, which benefited me a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
