ddupg commented on a change in pull request #2928:
URL: https://github.com/apache/hbase/pull/2928#discussion_r570883700



##########
File path: 
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTrackerZKImpl.java
##########
@@ -168,7 +169,7 @@ private boolean refreshOtherRegionServersList(boolean 
watch) {
     } else {
       synchronized (otherRegionServers) {
         otherRegionServers.clear();
-        otherRegionServers.addAll(newRsList);
+        
newRsList.stream().map(ServerName::parseServerName).forEach(otherRegionServers::add);

Review comment:
       Thank @wchevreuil for reviwing, your opinion is indeed better, I have 
revised it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to