sanjeetnishad95 commented on a change in pull request #2780:
URL: https://github.com/apache/hbase/pull/2780#discussion_r572894248
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1130,6 +1130,12 @@ private boolean isTableInGroup(TableName tableName,
String groupName,
if (region.isSplitParent()) {
continue;
}
+
+ // isSplitParent() and isSplit() is not always reliable. So for those
scenarios, better to
Review comment:
Hi Pankaj, thanks for reviewing. Found a pending TODO in
`org.apache.hadoop.hbase.master.assignment.AssignmentManager#markRegionAsSplit`
which explains why isSplit() is not reliable.
I have updated the MR by checking the region state instead of null server.
I am also planning to open another JIRA for resolving that TODO if come up
with a solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
