[ 
https://issues.apache.org/jira/browse/HBASE-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276764#comment-13276764
 ] 

rajeshbabu commented on HBASE-6016:
-----------------------------------

Yes,you are correct.

If we return false in case of disabling,we can aslo avoid creating znode and 
CloseRegionHandler/assign for already closed regions because 'assign' is false.
{code}
          if (assign) {
            ZKAssign.createOrForceNodeOffline(watcher, regionInfo,
                master.getServerName());
            if (!nodes.contains(regionInfo.getEncodedName())) {
              nodes.add(regionInfo.getEncodedName());
            }
{code}

By this we can only handle actual regions in transition. Its good.

Thanks. 
                
> ServerShutdownHandler#processDeadRegion could return false for disabling 
> table regions
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-6016
>                 URL: https://issues.apache.org/jira/browse/HBASE-6016
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>         Attachments: HBASE-6016.patch
>
>
> {code}
>    * @return Returns true if specified region should be assigned, false if 
> not.
>    * @throws IOException
>    */
>   public static boolean processDeadRegion(HRegionInfo hri, Result result,
>       AssignmentManager assignmentManager, CatalogTracker catalogTracker)
> {code}
> For the disabling region, I think we needn't assign it , and 
> processDeadRegion could return false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to