[
https://issues.apache.org/jira/browse/HBASE-25364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282703#comment-17282703
]
Hudson commented on HBASE-25364:
--------------------------------
Results for branch branch-2
[build #175 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/175/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/175/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/175/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/175/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/175/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/175//console].
> Redo the getMidPoint() in HFileWriterImpl to get rid of the double comparison
> process
> -------------------------------------------------------------------------------------
>
> Key: HBASE-25364
> URL: https://issues.apache.org/jira/browse/HBASE-25364
> Project: HBase
> Issue Type: Improvement
> Reporter: Zhuoyue Huang
> Assignee: Zhuoyue Huang
> Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> There is a TODO like this "TODO: Redo so only a single pass over the arrays
> rather than one to compare and then a second composing midpoint." in
> getMidpoint() of class HFileWriteImpl
>
> The old logic compares the left byte array and the right byte array twice：
> # A comparison is performed before composing MinimumMidpointArray
> # During composing of MinimumMidpointArray, bytes were comparing again
>
> My optimization combines them into one
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
