saintstack commented on a change in pull request #2949:
URL: https://github.com/apache/hbase/pull/2949#discussion_r575618690
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##########
@@ -468,9 +468,14 @@ private boolean deleteAction(Action<Boolean> deletion,
String type, Path dir) {
LOG.debug("Couldn't delete '{}' yet because it isn't empty
w/exception.", dir, exception);
deleted = false;
} catch (IOException ioe) {
- LOG.info("Could not delete {} under {}. might be transient; we'll retry.
if it keeps "
- + "happening, use following exception when asking on mailing list.",
- type, dir, ioe);
+ if (LOG.isTraceEnabled()) {
+ LOG.info("Could not delete {} under {}; will retry. If it keeps
happening, " +
+ "quote the exception when asking on mailing list.", type, dir,
ioe);
+ } else {
+ LOG.info("Could not delete {} under {}; will retry. If it keeps
happening, enable" +
+ "TRACE-level logging and quote the exception when asking on
mailing list.",
+ type, dir, ioe.getMessage());
Review comment:
This is a good one. Thank you. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
