[
https://issues.apache.org/jira/browse/HBASE-5959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276923#comment-13276923
]
Phabricator commented on HBASE-5959:
------------------------------------
tedyu has commented on the revision "HBASE-5959 [jira] Add other load
balancers".
More comments to follow.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:251
Do we need to re-fetch these config parameters in each iteration ?
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:44
There're extraneous empty lines such as this one.
Please remove them.
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:78
'one cluster' -> 'cluster with one server'
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:80
"it's" -> "cluster has"
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:197
'use' -> 'uses'
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:202
Please add javadoc
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:204
Typo: 'pickRandmoRegion' -> 'pickRandomRegion'
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:144
Remove empty line.
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:154
'plan' -> 'plans'
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:224
Please finish the sentence.
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:226
Specify what is returned.
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:241
'balancer.stochastic' -> 'stochastic.balancer'
src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:256
I think locality cost should be given higher weight.
REVISION DETAIL
https://reviews.facebook.net/D3189
To: JIRA, eclark
Cc: tedyu
> Add other load balancers
> ------------------------
>
> Key: HBASE-5959
> URL: https://issues.apache.org/jira/browse/HBASE-5959
> Project: HBase
> Issue Type: New Feature
> Components: master
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-5959-0.patch, HBASE-5959-1.patch,
> HBASE-5959-2.patch, HBASE-5959-3.patch, HBASE-5959-6.patch,
> HBASE-5959-7.patch, HBASE-5959.D3189.1.patch, HBASE-5959.D3189.2.patch,
> HBASE-5959.D3189.3.patch, HBASE-5959.D3189.4.patch
>
>
> Now that balancers are pluggable we should give some options.b
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
