shahrs87 commented on a change in pull request #2945: URL: https://github.com/apache/hbase/pull/2945#discussion_r576839923
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationLogQueue.java ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.replication.regionserver; + +import java.util.HashMap; +import java.util.Map; +import java.util.Queue; +import java.util.concurrent.PriorityBlockingQueue; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.util.EnvironmentEdgeManager; +import org.apache.hadoop.hbase.wal.AbstractFSWALProvider; +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.yetus.audience.InterfaceStability; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/* + Class that does enqueueing/dequeueing of wal at one place so that we can update the metrics + just at one place. + */ [email protected] [email protected] +public class ReplicationLogQueue { + // Queues of logs to process, entry in format of walGroupId->queue, + // each presents a queue for one wal group + private Map<String, PriorityBlockingQueue<Path>> queues = new HashMap<>(); + private MetricsSource metrics; + private Configuration conf; + // per group queue size, keep no more than this number of logs in each wal group + private int queueSizePerGroup; + // WARN threshold for the number of queued logs, defaults to 2 + private int logQueueWarnThreshold; + private ReplicationSource source; + private static final Logger LOG = LoggerFactory.getLogger(ReplicationSource.class); + + + public ReplicationLogQueue(Configuration conf, MetricsSource metrics, ReplicationSource source) { + this.conf = conf; + this.metrics = metrics; + this.source = source; + this.queueSizePerGroup = this.conf.getInt("hbase.regionserver.maxlogs", 32); + this.logQueueWarnThreshold = this.conf.getInt("replication.source.log.queue.warn", 2); + } + + /** + * Enqueue the wal + * @param wal wal to be enqueued + * @param walGroupId Key for the wal in @queues map + * @return boolean whether this is the first time we are seeing this walGroupId. + */ + public boolean enqueueLog(Path wal, String walGroupId) { + boolean exists = false; + PriorityBlockingQueue<Path> queue = queues.get(walGroupId); Review comment: I changed `queues` implementation from `HashMap` to `ConcurrentHashMap`. I thought your concern was regarding queues data structure. But reading the comment again, think you were concerned about `PriorityBlockingQueue` within map ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
