anmolnar commented on a change in pull request #2931:
URL: https://github.com/apache/hbase/pull/2931#discussion_r577021789



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java
##########
@@ -203,5 +213,21 @@ public double getCompactionPressure() {
   public Comparator<HStoreFile> getStoreFileComparator() {
     return storeFileComparator;
   }
+
+  void setStorefiles(ImmutableList<HStoreFile> storefiles) {
+    this.storefiles = storefiles;
+  }
+
+  void setCompactedfiles(ImmutableList<HStoreFile> compactedfiles) {

Review comment:
       Hm. My previous review has been lost in Github.
   
   I would rather create an abstract base class for DefaultStoreFileManager and 
PersistedStoreFileManager and put everything which is common in there.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to