petersomogyi commented on a change in pull request #2923:
URL: https://github.com/apache/hbase/pull/2923#discussion_r578348668
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java
##########
@@ -139,12 +140,17 @@ public TakeSnapshotHandler(SnapshotDescription snapshot,
final MasterServices ma
}
private TableDescriptor loadTableDescriptor()
- throws FileNotFoundException, IOException {
+ throws IOException {
TableDescriptor htd =
this.master.getTableDescriptors().get(snapshotTable);
if (htd == null) {
throw new IOException("TableDescriptor missing for " + snapshotTable);
}
+ if(htd.getMaxFileSize()==-1 &&
Review comment:
> When we have max file size already set on a table (at src cluster) we
will be preserving it in snapshot's HTD anyways right. Just confirming.
Yes, it won't be overridden by the system's region size configuration.
>Also while taking snapshot, we can pass in this new config
hbase.snapshot.max.filesize.preserve = true right?
Very useful feature.
The current proposal sets this at the system level so all snapshots taken
will use this. I'd also like this configuration to be passed at snapshot
creation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
