symat commented on pull request #2989: URL: https://github.com/apache/hbase/pull/2989#issuecomment-786477336
@wchevreuil thanks for the quick review! > LGTM. I guess the slight change in behaviour not an issue to backport it to branch-2.2? this change is only introducing extra checks on the master Rpc API called by hbck2. Even if there would be difference inthe assignment procedure between 2.2 and 2.3, these checks happen before the procedure would be even triggered. I tested the change on a 2.2 cluster, and after applying this change: - assign/unassign of regions both in OPEN or CLOSED state works as expected using the HBase shell - HBCK2 command 'assigns' on an OPEN region doesn't succeed and doesn't screw up anything in HBase master. Using the --override flag will bypass the check and will result stuck RIT and also OPENING state in the meta. - HBCK2 command 'assigns' on a CLOSED region works as expected and assigns the region - HBCK2 command 'unassigns' on an OPEN region works as expected and unassigns the region - HBCK2 command 'unassigns' on an CLOSED region doesn't succeed. You need to providee the --override flag to bypass the checks. But actually in this case it is harmless (AFAICS HBsae master state won't change after the unassign procedure on a CLOSED region) p.s. I'll check the checkstyle problems soon ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
