searlapati commented on pull request #2901: URL: https://github.com/apache/hbase/pull/2901#issuecomment-787134423
Please unsubscribe me On Fri, Jan 22, 2021, 11:06 AM Duo Zhang <[email protected] wrote: > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/hbase/pull/2901 > Commit Summary > > - HBASE-25373 Remove HTrace completely in code base and try to make > use of OpenTelemetry > - HBASE-25401 Add trace support for async call in rpc client (#2790) > - HBASE-25424 Find a way to config OpenTelemetry tracing without > direct… (#2808) > - HBASE-23898 Add trace support for simple apis in async client (#2813) > - HBASE-25454 Add trace support for connection registry (#2828) > - HBASE-25481 Add host and port attribute when tracing rpc call at > client side (#2857) > - HBASE-25455 Add trace support for HRegion read/write operation > (#2861) > - HBASE-25484 Add trace support for WAL sync (#2892) > > File Changes > > - *M* bin/hbase > <https://github.com/apache/hbase/pull/2901/files#diff-a39e2a7eaf4eb8191f3c95be03255df721e92fd926ef649b50134c5270068805> > (10) > - *M* conf/hbase-env.sh > <https://github.com/apache/hbase/pull/2901/files#diff-01a9e084fae78f237f012c0fb7137d43e09547bd0bd0d4410ee0b9f5dc3162dc> > (5) > - *M* hbase-assembly/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-e5d5d036897252ddc1861151efad1586e0b8b5347105aba6bc5c78a2f55c1cb2> > (6) > - *M* hbase-assembly/src/main/assembly/hadoop-three-compat.xml > <https://github.com/apache/hbase/pull/2901/files#diff-3245893b838247ac80130558cebcbbb4d3fb8346c4290a127314be8d965b18ac> > (9) > - *M* > hbase-asyncfs/src/test/java/org/apache/hadoop/hbase/io/asyncfs/AsyncFSTestBase.java > <https://github.com/apache/hbase/pull/2901/files#diff-f4d1570b28b218d9840a999768642ff07eeb59b1765be52e1d7b9aac988fa4d2> > (4) > - *M* hbase-client/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-5efd3adf59ddfcb9f73f89c342968025eaf26ef2dbc3dfc5097e2d55d4508dcb> > (14) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnection.java > <https://github.com/apache/hbase/pull/2901/files#diff-63cea6bc512687e2c92cfc78a9414d9ba1eb37381254a52ed71ec3e4397bebc7> > (4) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java > <https://github.com/apache/hbase/pull/2901/files#diff-909d5baed55f081d97f55bac26c2baf03aa5d9732a0a2abe00d03dd8bbb02883> > (114) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java > <https://github.com/apache/hbase/pull/2901/files#diff-0c27a736c397425702b0678a58ea1336d70d0358f5c6bd522eae883ba2408025> > (165) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java > <https://github.com/apache/hbase/pull/2901/files#diff-d4af2aceac4583749bdcab9c245dc125b34f524b3850d0538ac0cf7c1e3c1d66> > (41) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableRegionLocatorImpl.java > <https://github.com/apache/hbase/pull/2901/files#diff-6bcbe405bd6469b1f5169a57f950d429372106ec0846e076f527a8c95a9ce77f> > (18) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java > <https://github.com/apache/hbase/pull/2901/files#diff-642e7cf45cc064fd741acfbcacd944385befa82cc62c5b5d7e6acde7169d41fd> > (55) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java > <https://github.com/apache/hbase/pull/2901/files#diff-94c41b03f67414ded10306aa5fea39f498d12fa366aee2254a2354dd7dd383fa> > (63) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java > <https://github.com/apache/hbase/pull/2901/files#diff-7ab88c464bf7557dd7e4ff33ab640c4a8401126c0bbe1c0916c698dcef7f8b3b> > (356) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java > <https://github.com/apache/hbase/pull/2901/files#diff-ef2a49161d81ce722bdb25efe21f7e8ae288db252d2c494581232b2040f92c49> > (36) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java > <https://github.com/apache/hbase/pull/2901/files#diff-8f447eb8fd29c1250a7ad545ac11ffca657aebbbdadccfad297b303b40623994> > (81) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java > <https://github.com/apache/hbase/pull/2901/files#diff-1a7ec27a8107293b6c87132823c262fc250570687a40f45646c43ae46dc6b04e> > (18) > - *M* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/Call.java > <https://github.com/apache/hbase/pull/2901/files#diff-fdab4c888f0b40d1db0dfa6f9a93c88084f54edb59eb0fee2fd110b68b7f3b20> > (9) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/IPCUtil.java > <https://github.com/apache/hbase/pull/2901/files#diff-75621c1fe7545bd94c5d8e80f73f329f6e7e05aad56e70e4253108cbab1faf70> > (12) > - *M* > hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.java > <https://github.com/apache/hbase/pull/2901/files#diff-5b25140e530fd6a4afc8834596692bacce5b7e4793a759dc832158e411f3ef5f> > (8) > - *A* > hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionLocatorTracing.java > <https://github.com/apache/hbase/pull/2901/files#diff-938eb0166c050ef27e6a9c4f0c55928a955e8501086d4d88b51ca3560a6126b8> > (157) > - *A* > hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java > <https://github.com/apache/hbase/pull/2901/files#diff-33f452f6ec3fd54dcb8cd04aa3abc9d8c8e9c1fa848313e5f120e782e4c3b41f> > (414) > - *M* hbase-common/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-69debd9f2b708cb88003fe734f191a428a715dc9b8903dd226fc5c1e741d9a65> > (4) > - *D* > hbase-common/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java > <https://github.com/apache/hbase/pull/2901/files#diff-8d39bd33d11e6909c1d48ca11c118532433e3f81f7817e9f624093bc929b5b72> > (80) > - *D* > hbase-common/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java > <https://github.com/apache/hbase/pull/2901/files#diff-9810c454d2300d4fcc691c30698c9ace5312b1473254c7aa8964c189e1047275> > (120) > - *M* > hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java > <https://github.com/apache/hbase/pull/2901/files#diff-1dd151076d14141bd9956eb8b7f605d0fe149cdf4d7b3795ad2599906246878e> > (211) > - *M* hbase-external-blockcache/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-9120c301e621b76ee06cd60d27e5efe8f9b1ee724ec8bff51015be8d1812ed70> > (4) > - *M* > hbase-external-blockcache/src/main/java/org/apache/hadoop/hbase/io/hfile/MemcachedBlockCache.java > <https://github.com/apache/hbase/pull/2901/files#diff-e768f740020f54f0175cd4871230232045d62bda4eeeff49b422946b9efb1bc2> > (14) > - *M* hbase-it/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-157cb3687b2b5ac691bbef57dcd9c9a45942c10c0ce0265b2d5fd1fda7d29963> > (4) > - *M* > hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java > <https://github.com/apache/hbase/pull/2901/files#diff-53e89d97650befe01013f50da941c9a326ef39beb139ac753b0e0d6104400502> > (21) > - *M* > hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java > <https://github.com/apache/hbase/pull/2901/files#diff-c31e8a6e785399e80c3e1ae978b9fbaf92c12362b906588968e48b99eab531a8> > (127) > - *M* hbase-mapreduce/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-bfea5879156a1ca50c50d0b1e8335a87a8f246a898813bc683836b580427d714> > (4) > - *M* > hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java > <https://github.com/apache/hbase/pull/2901/files#diff-206a47991334f3d0234e2289313df05197e762b8c5ecdb4497deff1d55947a23> > (29) > - *M* hbase-protocol-shaded/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-e16e8187043b58c6640a7874cfb94ccb226b1614d523a826fcb56c19ff4cdebf> > (4) > - *M* hbase-protocol-shaded/src/main/protobuf/rpc/Tracing.proto > <https://github.com/apache/hbase/pull/2901/files#diff-aa2c78773372d392ca848f5c8df4ba8400550f0687bf2314525ce226c7b2cb53> > (14) > - *M* hbase-server/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-175f7e0920477b589c8cdb0d2f1a5dc683026c6117ffa8ad897937731c5012b5> > (14) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java > <https://github.com/apache/hbase/pull/2901/files#diff-b914051730d36d00e59415ef640d945cd8b63e76884814977576b1a209ce821a> > (16) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java > <https://github.com/apache/hbase/pull/2901/files#diff-c910a49e7d962e49b199d22f38e1cd78d867351208b86bffdd56ffb9aa1aa596> > (11) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java > <https://github.com/apache/hbase/pull/2901/files#diff-a9f03313b5cc5faadaa8a9ecfb3bf9280a819c0e39d4d2fc03d35efb5fec785c> > (53) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java > <https://github.com/apache/hbase/pull/2901/files#diff-5acb3c372e2d36a6887e9979143a07136af0eccbc03f2a132236ec1ef4818600> > (14) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java > <https://github.com/apache/hbase/pull/2901/files#diff-b59fac49dace4a9c5f427d064d70cdebb80aed1bfe45b8fd8fd22bc2017cbb3d> > (221) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java > <https://github.com/apache/hbase/pull/2901/files#diff-0e55b368bd805325243956ccd037e06bf8954c2c2cb99b665a1dd4c88f26f97b> > (2) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java > <https://github.com/apache/hbase/pull/2901/files#diff-e1b3a4f01562665374c08ac40a40498842a98e54fe8d05c5a34f246ff757bf25> > (6) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > <https://github.com/apache/hbase/pull/2901/files#diff-a754d10861bd8d44a6fac8dd2257b1154a03415851613d8b3cd3e99964713d7f> > (197) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > <https://github.com/apache/hbase/pull/2901/files#diff-28c35e580c673c9cff5b5b4751fc368b98784a667c12f86abbd8f84d2e89d151> > (9) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java > <https://github.com/apache/hbase/pull/2901/files#diff-51a63480948281229a68d3e9476edc63013ab3a7328d327071ed4ca8c3b654fa> > (8) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java > <https://github.com/apache/hbase/pull/2901/files#diff-6801da4cb2def19652841f4b3c3c01d84f1885973f9307b8ecf95a227534a154> > (14) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java > <https://github.com/apache/hbase/pull/2901/files#diff-9d247127dd79427ba0afca575571395b7a128ab1ecdf462efbed290c5ae4403d> > (109) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java > <https://github.com/apache/hbase/pull/2901/files#diff-a3e81bc41e6d5b37159c9f897fa97f9c957cc1d164a7e201bcf90770d17557a8> > (70) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java > <https://github.com/apache/hbase/pull/2901/files#diff-e7e178e33448c1260952bf21247987de0b837b0557fe71d049760fe16940be47> > (110) > - *M* > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java > <https://github.com/apache/hbase/pull/2901/files#diff-aaeb20ce1167716648486517a3e904b0de6c666ec1f6aa2951c197166dd2a4f4> > (42) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java > <https://github.com/apache/hbase/pull/2901/files#diff-7b3f8afdc99c76d39fa10cbd4a70f9579d32194fe6d27b93fb5a46f7ba1f92bb> > (4) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/TestExecutorStatusChore.java > <https://github.com/apache/hbase/pull/2901/files#diff-18e8069d0a430b3293392633c73f264b51982aee165145cc1590bc0a43e72232> > (8) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java > <https://github.com/apache/hbase/pull/2901/files#diff-6b74bc29f8222310cfa262c1588dc376de0faca983bdca2737057fbcafef169c> > (4) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java > <https://github.com/apache/hbase/pull/2901/files#diff-98897f5ef718b26fa0600d3d5f6a226f901c52ea405ceac33640692cf62f6e18> > (74) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyIPC.java > <https://github.com/apache/hbase/pull/2901/files#diff-d648340a068f936a6ee99be71d3f1303c81a492a85e223c0c63df160b81ef4c2> > (1) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java > <https://github.com/apache/hbase/pull/2901/files#diff-17935270549bb480d215294a8f16cc6445502cd706a07b026e3ee04456ce5413> > (2) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java > <https://github.com/apache/hbase/pull/2901/files#diff-61bd3c8b9c1810bc215a0b5c1ba9ba89d033adbcfcb4728e7233524f45dc4806> > (4) > - *A* > hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionTracing.java > <https://github.com/apache/hbase/pull/2901/files#diff-89b09e08222c8f7b098e80ff4409ad4c46389fcb8c6d399bdcd97c057405a2f6> > (187) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestAsyncFSWALDurability.java > <https://github.com/apache/hbase/pull/2901/files#diff-4060de9b45353e88d23d162c81ef8c94e98c6e95f1e18c3d3fb556b26989efa3> > (8) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLogDurability.java > <https://github.com/apache/hbase/pull/2901/files#diff-1f24cade96bc2b6979debcbf6cb628457a73eff18e183c6150840f5a274ec3b5> > (8) > - *D* > hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TestHTraceHooks.java > <https://github.com/apache/hbase/pull/2901/files#diff-3c30f21e0d0b97f017025eb836bbec3138342f7394a26308deb95b49b83b650c> > (134) > - *D* > hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TraceTree.java > <https://github.com/apache/hbase/pull/2901/files#diff-f080d3df18e42426bb4639a8cc145d3c689434b051b9851c2db5af94fd6d24df> > (148) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/wal/FaultyFSLog.java > <https://github.com/apache/hbase/pull/2901/files#diff-fa6ed7b43487b3292126ce0900719cff3d1219674dc091405a017d3658ddaf33> > (10) > - *M* > hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALPerformanceEvaluation.java > <https://github.com/apache/hbase/pull/2901/files#diff-92f5009e0a7409c410c0c66e3b3ddb5f3d85d76f4a8fa42f8a0a39b45fffcdd1> > (73) > - *M* hbase-shaded/hbase-shaded-client/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-972f4c37877e45aa4c1b48db458d65c9a7896adf5f4727d5a4b076a0e577fe00> > (1) > - *M* hbase-shaded/hbase-shaded-testing-util/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-f6dcf7508e2a8a0aefb12fe7157f419d0c6d2aa506b5d868be36d32131bea590> > (1) > - *M* hbase-shaded/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-d33c20ffa55688459cae40b0f418970a13b5b781aa55a40e2126f2d65f25295a> > (1) > - *M* hbase-shell/src/main/ruby/shell/commands/trace.rb > <https://github.com/apache/hbase/pull/2901/files#diff-55afb1c4d442e995324711ea07e740715d75238c17d52cd3f09a1867975fa0ba> > (43) > - *M* hbase-zookeeper/pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-bd54b12c4ead53266a65695b7372ae9c5fdf87feebd3d474a039bcff63883fb6> > (4) > - *M* > hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java > <https://github.com/apache/hbase/pull/2901/files#diff-bf7d5d1d86d9e0e87555d6b9f21fb626271837562f224c959417786e9a45e5fa> > (65) > - *M* pom.xml > <https://github.com/apache/hbase/pull/2901/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8> > (46) > > Patch Links: > > - https://github.com/apache/hbase/pull/2901.patch > - https://github.com/apache/hbase/pull/2901.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/hbase/pull/2901>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC4NUFCEP7C5SNNS6ILLXIDS3EFF5ANCNFSM4WN65P5A> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
