taklwu commented on a change in pull request #2931: URL: https://github.com/apache/hbase/pull/2931#discussion_r585247357
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StorefileTrackingUtils.java ########## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.regionserver; + +import java.io.IOException; +import java.util.Collection; +import java.util.List; +import java.util.concurrent.TimeUnit; +import java.util.stream.Collectors; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.MetaTableAccessor; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.Connection; +import org.apache.hadoop.hbase.master.MasterServices; +import org.apache.hadoop.hbase.util.EnvironmentEdgeManager; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Utility class to support persistent storefile tracking + */ [email protected] +public final class StorefileTrackingUtils { + + private static Logger LOG = LoggerFactory.getLogger(StorefileTrackingUtils.class); + public static final long SLEEP_DELTA_MS = TimeUnit.MILLISECONDS.toMillis(100); + + private StorefileTrackingUtils() { + // private for utility class + } + + public static boolean isStorefileTrackingPersistEnabled(Configuration conf) { + boolean isStoreTrackingPersistEnabled = + conf.getBoolean(HConstants.STOREFILE_TRACKING_PERSIST_ENABLED, + HConstants.DEFAULT_STOREFILE_TRACKING_PERSIST_ENABLED); + boolean isPersistedStoreEngineSet = + conf.get(StoreEngine.STORE_ENGINE_CLASS_KEY, DefaultStoreEngine.class.getName()) + .equals(PersistedStoreEngine.class.getName()); + boolean isFeatureEnabled = isStoreTrackingPersistEnabled && isPersistedStoreEngineSet; + if (isStoreTrackingPersistEnabled ^ isPersistedStoreEngineSet) { + // check if both configuration are correct. + String errorMessage = String.format("please set %s to true and set store engine key %s to %s " + + "to enable persist storefile tracking", + HConstants.STOREFILE_TRACKING_PERSIST_ENABLED, + StoreEngine.STORE_ENGINE_CLASS_KEY, PersistedStoreEngine.class.getName()); + throw new IllegalArgumentException(errorMessage); + } + return isFeatureEnabled; + } + + /** + * if storefile tracking feature is configured, Initialize hbase:storefile table and wait for it + * to be online. Otherwise, look for hbase:storefile table and remove it + * + * @param masterServices masterServices + * @throws IOException if hbase:storefile table cannot be initialized and be online + */ + public static void init(MasterServices masterServices) throws IOException { + createStorefileTable(masterServices); + waitForStoreFileTableOnline(masterServices); + } + + /** + * Cleans up all storefile related state on the cluster. disable and delete hbase:storefile + * if found + * @param masterServices {@link MasterServices} + * @throws IOException if failures + */ + private static void cleanup(MasterServices masterServices) throws IOException { Review comment: removed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
