pankaj72981 commented on a change in pull request #2958:
URL: https://github.com/apache/hbase/pull/2958#discussion_r586088720
##########
File path:
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/client/ThriftConnection.java
##########
@@ -160,14 +160,16 @@ public int getConnectTimeout() {
@Override
public Pair<THBaseService.Client, TTransport> getClient() throws
IOException {
- TSocket sock = new TSocket(connection.getHost(), connection.getPort());
- sock.setSocketTimeout(connection.getOperationTimeout());
- sock.setConnectTimeout(connection.getConnectTimeout());
- TTransport tTransport = sock;
- if (connection.isFramed()) {
- tTransport = new TFramedTransport(tTransport);
- }
+ TTransport tTransport = null;
Review comment:
In 0.14.0, TSocket constructor throws TTransportException, so guarded
inside try-catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
