[
https://issues.apache.org/jira/browse/HBASE-25385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294949#comment-17294949
]
Duo Zhang commented on HBASE-25385:
-----------------------------------
Oh, I've also seen failures in a few pre commit results.
Glad to see the root cause.
Let me think how to make it more robust. Maybe we do not need to test for all
the time zones.
> TestCurrentHourProvider fails if the latest timezone changes are not present
> ----------------------------------------------------------------------------
>
> Key: HBASE-25385
> URL: https://issues.apache.org/jira/browse/HBASE-25385
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.4.1
> Reporter: Christine Feng
> Assignee: Andrew Kyle Purtell
> Priority: Blocker
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.2
>
>
> According to [this
> link|https://www.oracle.com/java/technologies/tzdata-versions.html], a few
> timezones underwent changes in October of this year. For environments that do
> not have these latest updates, TestCurrentHourProvider will fail since
> information for certain time zones is out of date.
> Example: On an environment running jdk8, this test fails for timezones
> America/Dawson, America/Whitehorse, Canada/Yukon, and Antarctica/Casey (all
> of which were affected by the latest changes described at the above link).
> It seems that if timezone information on a particular environment is not up
> to date with the latest changes, this shouldn't indicate a failure of
> CurrentHourProvider, especially since this test specifically tests the
> functionality of CurrentHourProvider and using EnvironmentEdgeManager to mock
> time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
