virajjasani commented on a change in pull request #3024:
URL: https://github.com/apache/hbase/pull/3024#discussion_r589487829
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -263,6 +263,10 @@ protected void
setCandidateGenerators(List<CandidateGenerator> customCandidateGe
this.candidateGenerators = customCandidateGenerators;
}
+ public List<CandidateGenerator> getCandidateGenerators() {
Review comment:
Since we are allowing mutating the list, can you add a comment that this
method is only for test purpose?
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java
##########
@@ -71,7 +71,7 @@
public class SecureTestUtil {
private static final Logger LOG =
LoggerFactory.getLogger(SecureTestUtil.class);
- private static final int WAIT_TIME = 10000;
+ private static final int WAIT_TIME = 30000;
Review comment:
Is this required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
