sunhelly commented on a change in pull request #3025:
URL: https://github.com/apache/hbase/pull/3025#discussion_r591505190
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeLoadBalancer.java
##########
@@ -89,7 +89,7 @@ public synchronized void initialize() throws HBaseIOException
{
}
@Override
- public List<RegionPlan> balanceTable(TableName tableName,
+ public List<RegionPlan> balanceTablePlans(TableName tableName,
Review comment:
balanceTable() only generates plans without executing them. I add a
method balanceRSGroup(), which generates plans and executes them.
For distinguishing these two meanings, I changed the method name.
If it is not necessary, I can remove these changes, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
