[ 
https://issues.apache.org/jira/browse/HBASE-25664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301401#comment-17301401
 ] 

Sandeep Pal commented on HBASE-25664:
-------------------------------------

I believe it is this _"It is still being deleted in the background"._

This is because queue removal depends upon zk listener being invoked after the 
peer node gets deleted. This may get delayed since there is no guarantee of 
when the zk notification will be there(I am referring to branch-1).

 >This may cause trouble for the RemovePeerProcedure?
I believe we need to handle it accordingly if the queue is already deleted. 
But IMO, hbase should not prevent peer creation if a queue exists.

Let me know what you think?

> Adding replication peer should handle the undeleted queue exception
> -------------------------------------------------------------------
>
>                 Key: HBASE-25664
>                 URL: https://issues.apache.org/jira/browse/HBASE-25664
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sandeep Pal
>            Assignee: Sandeep Pal
>            Priority: Major
>
> Currently, if we try to add a peer and there is a replication queue existing 
> for that peer, it doesn't let the replication peer created. 
> Instead, we should delete the queue and proceed with the creating of 
> replication peer. Any queue without no corresponding replication peer is 
> useless anyway. So, we shouldn't wait for cleaner to come and clean it before 
> creating the peer. 
>  
> {code:java}
> org.apache.hadoop.hbase.replication.ReplicationException: undeleted queue for 
> peerId: xyz_peerid, replicator: hostname.fakeaddress.com,60020,1607576586258, 
> queueId: xyz_peerid
> java.lang.RuntimeException: 
> org.apache.hadoop.hbase.replication.ReplicationException: undeleted queue for 
> peerId: xyz_peerid, replicator: hostname.fakeaddress.com,60020,1607576586258, 
> queueId: xyz_peerid
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to