saintstack commented on a change in pull request #1708:
URL: https://github.com/apache/hbase/pull/1708#discussion_r594635502
##########
File path: bin/hbase
##########
@@ -775,25 +783,31 @@ HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
HBASE_OPTS="$HBASE_OPTS -Dhbase.id.str=$HBASE_IDENT_STRING"
-HBASE_OPTS="$HBASE_OPTS -Dhbase.root.logger=${HBASE_ROOT_LOGGER:-INFO,console}"
+HBASE_OPTS="$HBASE_OPTS
-Dhbase.root.logger.level=${HBASE_ROOT_LOGGER_LEVEL:-INFO}"
+HBASE_OPTS="$HBASE_OPTS
-Dhbase.root.logger.appender=${HBASE_ROOT_LOGGER_APPENDER:-console}"
Review comment:
If HBASE_ROOT_LOGGER defined, do you want to try parsing it and using
result to populate HBASE_ROOT_LOGGER_LEVEL, etc.
##########
File path: bin/hbase
##########
@@ -658,7 +663,10 @@ elif [ "$COMMAND" = "mapredcp" ] ; then
for f in "${HBASE_HOME}"/lib/client-facing-thirdparty/*.jar; do
if [[ ! "${f}" =~ ^.*/htrace-core-3.*\.jar$ ]] && \
[ "${f}" != "htrace-core.jar$" ] && \
- [[ ! "${f}" =~ ^.*/slf4j-log4j.*$ ]]; then
+ [[ ! "${f}" =~ ^.*/log4j.*$ ]] && \
+ [[ ! "${f}" =~ ^.*/slf4j.*$ ]] && \
+ [[ ! "${f}" =~ ^.*/jcl-over-slf4j.*$ ]] && \
+ [[ ! "${f}" =~ ^.*/jul-to-slf4j.*$ ]]; then
Review comment:
Make a function of this filtering so don't have to repeat code?
##########
File path: bin/hbase
##########
@@ -775,25 +783,31 @@ HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
HBASE_OPTS="$HBASE_OPTS -Dhbase.id.str=$HBASE_IDENT_STRING"
-HBASE_OPTS="$HBASE_OPTS -Dhbase.root.logger=${HBASE_ROOT_LOGGER:-INFO,console}"
+HBASE_OPTS="$HBASE_OPTS
-Dhbase.root.logger.level=${HBASE_ROOT_LOGGER_LEVEL:-INFO}"
+HBASE_OPTS="$HBASE_OPTS
-Dhbase.root.logger.appender=${HBASE_ROOT_LOGGER_APPENDER:-console}"
Review comment:
Yeah, incompatible change but good for hbase3 I'd say.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
