saintstack commented on a change in pull request #3054:
URL: https://github.com/apache/hbase/pull/3054#discussion_r595394923
##########
File path: bin/graceful_stop.sh
##########
@@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f`
if [ "$localhostname" == "$hostname" ]; then
local=true
fi
+if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then
+ local=true
+ hostname=$localhostname
Review comment:
Thanks @javierluca . Thanks for digging in here.
Thanks for turning-up the 'overloading' of 'localhost'.
Above looks reasonable. Do we have to repeat the 'if [ "$localhostname" ==
"$hostname" ] ...' and the setting of local = true: i.e. do we need lines
#108-110 in above now you've added #111-114?
Lets open new issue for this further discussion so we don't muddle JIRA+PR
intent.
Thanks.
##########
File path: bin/graceful_stop.sh
##########
@@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f`
if [ "$localhostname" == "$hostname" ]; then
local=true
fi
+if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then
+ local=true
+ hostname=$localhostname
Review comment:
Oh, on the ports for regionservers.sh, I think its just lazyness that
they are hardcoded. Can change that in another issue.... Use
HBASE_RS_BASE_PORT and HBASE_RS_INFO_BASE_PORT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
