lzx404243 commented on a change in pull request #2984:
URL: https://github.com/apache/hbase/pull/2984#discussion_r597382058
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
##########
@@ -146,6 +147,7 @@ public void testIsFileDeletable() throws IOException,
ReplicationException {
assertFalse("Cleaner should not allow to delete this file as there is a
hfile reference node "
+ "for it in the queue.",
cleaner.isFileDeletable(fs.getFileStatus(file)));
+ rq.removeHFileRefs(peerId,
Arrays.asList("testIsFileDeletableWithNoHFileRefs"));
Review comment:
Thanks for reviewing. The HFileRef is created in a specific test, so I
think it makes sense to remove it at the end of this test. Alternatively, what
I can do is to remove all HFileRefs in the tearDown method (if any). Do you
want me to pursue the latter option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
