[GitHub] [hbase] Reidddddd commented on a change in pull request #3066: HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

[GitBox]

Reidddddd commented on a change in pull request #3066:
URL: https://github.com/apache/hbase/pull/3066#discussion_r597392124



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -2901,16 +2901,17 @@ private void scan(HBaseRpcController controller, 
ScanRequest request, RegionScan
     // arbitrary 32. TODO: keep record of general size of results being 
returned.
     List<Cell> values = new ArrayList<Cell>(32);
     region.startRegionOperation(Operation.SCAN);
+    long before = EnvironmentEdgeManager.currentTime();
+    // Used to check if we've matched the row limit set on the Scan
+    int numOfCompleteRows = 0;
+    // Count of times we call nextRaw; can be > numOfCompleteRows.
+    int numOfNextRawCalls = 0;
     try {
       int numOfResults = 0;
-      int numOfCompleteRows = 0;
-      long before = EnvironmentEdgeManager.currentTime();
       synchronized (scanner) {
         boolean stale = (region.getRegionInfo().getReplicaId() != 0);
-        boolean clientHandlesPartials =
-            request.hasClientHandlesPartials() && 
request.getClientHandlesPartials();
-        boolean clientHandlesHeartbeats =
-            request.hasClientHandlesHeartbeats() && 
request.getClientHandlesHeartbeats();
+        boolean clientHandlesPartials = request.hasClientHandlesPartials() && 
request.getClientHandlesPartials();
+        boolean clientHandlesHeartbeats = request.hasClientHandlesHeartbeats() 
&& request.getClientHandlesHeartbeats();

Review comment:
       Please don't change something unrelated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org