Reidddddd commented on a change in pull request #3066:
URL: https://github.com/apache/hbase/pull/3066#discussion_r598741228
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3053,21 +3053,22 @@ private void scan(HBaseRpcController controller,
ScanRequest request, RegionScan
builder.setScanMetrics(metricBuilder.build());
}
}
+ } finally {
+ region.closeRegionOperation();
+ // Update serverside metrics, even on error.
long end = EnvironmentEdgeManager.currentTime();
long responseCellSize = context != null ? context.getResponseCellSize()
: 0;
region.getMetrics().updateScanTime(end - before);
if (regionServer.metricsRegionServer != null) {
- regionServer.metricsRegionServer.updateScanSize(
- region.getTableDesc().getTableName(), responseCellSize);
- regionServer.metricsRegionServer.updateScanTime(
- region.getTableDesc().getTableName(), end - before);
+
regionServer.metricsRegionServer.updateScanSize(region.getTableDesc().getTableName(),
responseCellSize);
+
regionServer.metricsRegionServer.updateScanTime(region.getTableDesc().getTableName(),
end - before);
+ regionServer.metricsRegionServer
+ .updateReadQueryMeter(region.getRegionInfo().getTable(),
numOfNextRawCalls);
+ }
+ // coprocessor postNext hook
+ if (region.getCoprocessorHost() != null) {
Review comment:
Still, I got no answer about this 'why'. Could you remove this
`if (region.getCoprocessorHost() != null) {` branch out of final block, and
stick to the parent task's pull request's changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
