bharathv commented on a change in pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#discussion_r600034457
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
##########
@@ -176,7 +176,7 @@ private void testSanity(final String testName) throws
Exception {
@Test
public void testRegionAssignmentAfterMasterRecoveryDueToZKExpiry() throws
Exception {
MiniHBaseCluster cluster = TEST_UTIL.getHBaseCluster();
- cluster.startRegionServer();
+ cluster.startRegionServerAndWait(2000);
Review comment:
Sorry I was busy, just reading thru the comments.
> If "online" for a regionserver should mean that the regionserver has
communicated to master it's ready to be assigned regions, then online should be
set after the first reportForDuty.
This... Earlier (without your patch), "online" meant this ^^. Now with your
patch, the semantics have changed, so what @saintstack is saying (IIUC) is to
preserve those semantics by setting it after the first `reportForDuty` and then
you don't have to make any changes to the tests (if this theory is correct).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
