caroliney14 commented on a change in pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#discussion_r601838144
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -1050,7 +1050,7 @@ public void run() {
}
}
- // We registered with the Master. Go into run mode.
+ // Run mode.
long lastMsg = System.currentTimeMillis();
Review comment:
@saintstack do we have to do this one? asking because the `lastMsg`
timestamp ultimately ends up getting stored
[here](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1425),
not sure if it'll have any impact we care about. also, one stage of the PR
build kept failing for some unknown reason when I had pushed up the change
`long lastMsg = 0;` which is why I ended up undoing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
