saintstack commented on a change in pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#discussion_r601870036
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -1050,7 +1050,7 @@ public void run() {
}
}
- // We registered with the Master. Go into run mode.
+ // Run mode.
long lastMsg = System.currentTimeMillis();
Review comment:
No. We not have to do it. It was suggestion. You've done a mountain of
great work in here already.
I'll keep an eye on it. Was thinking we heartbeat immediately but that might
not be a good idea on a big cluster....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
