[
https://issues.apache.org/jira/browse/HBASE-25658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313269#comment-17313269
]
Duo Zhang commented on HBASE-25658:
-----------------------------------
Test scan again.
Master branch
{noformat}
Scan: 88711 row per second
[ Avg TPS/QPS] 88558 row per second
[ Avg TPS/QPS] 88458 row per second
[ Avg TPS/QPS] 89116 row per second
{noformat}
HBASE-22120 with trace disabled.
{noformat}
Scan: 87730 row per second
[ Avg TPS/QPS] 88241 row per second
[ Avg TPS/QPS] 87263 row per second
[ Avg TPS/QPS] 87687 row per second
{noformat}
HBASE-22120 with trace enabled and ratio 1.0.
{noformat}
Scan: 87374 row per second
[ Avg TPS/QPS] 86512 row per second
[ Avg TPS/QPS] 87449 row per second
[ Avg TPS/QPS] 88160 row per second
{noformat}
So comparing to master branch.
The diff for HBASE-22120 with trace disabled is ~-1.1%
THe diff for HBASE-22120 with trace enabled and ratio as 1.0 is ~-1.5%
So after removing the trace for RegionScanner.next, the performance impact is
acceptable.
Let me file a new issue to remove the trace for RegionScanner.next, and then
fill up the documentation, then I think it is time to merge this branch back to
master.
Thanks.
> Basic benchmark to show the impact on performance for tracing
> -------------------------------------------------------------
>
> Key: HBASE-25658
> URL: https://issues.apache.org/jira/browse/HBASE-25658
> Project: HBase
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
