[
https://issues.apache.org/jira/browse/HBASE-25745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317752#comment-17317752
]
Baiqiang Zhao commented on HBASE-25745:
---------------------------------------
Thanks [~ndimiduk], put up a PR for master branch. By the way, I find that the
following log always prints when BLOCKCACHE_BLOCKSIZE_KEY is configured but
DEPRECATED_BLOCKCACHE_BLOCKSIZE_KEY is not configured in the conf file.
{code:java}
if (conf.get(DEPRECATED_BLOCKCACHE_BLOCKSIZE_KEY) != null) {
LOG.warn("The config key {} is deprecated now, instead please use {}. In
future release "
+ "we will remove the deprecated config.",
DEPRECATED_BLOCKCACHE_BLOCKSIZE_KEY,
BLOCKCACHE_BLOCKSIZE_KEY);
}
{code}
I think this is not up to expectations. The reason for this phenomenon is that
the following code:
{code:java}
Configuration.addDeprecation(DEPRECATED_BLOCKCACHE_BLOCKSIZE_KEY,
BLOCKCACHE_BLOCKSIZE_KEY);
{code}
> Deprecate/Rename config `hbase.normalizer.min.region.count` to
> `hbase.normalizer.merge.min.region.count`
> --------------------------------------------------------------------------------------------------------
>
> Key: HBASE-25745
> URL: https://issues.apache.org/jira/browse/HBASE-25745
> Project: HBase
> Issue Type: Improvement
> Components: master, Normalizer
> Affects Versions: 3.0.0-alpha-1, 2.5.0
> Reporter: Nick Dimiduk
> Assignee: Baiqiang Zhao
> Priority: Minor
>
> After HBASE-24416, {{hbase.normalizer.min.region.count}} only applies to
> merge plans. Let's deprecate/rename the configuration key so that it is clear
> in what context it applies, and so that it matches the configuration
> structure of related keys.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
