saintstack commented on a change in pull request #3184:
URL: https://github.com/apache/hbase/pull/3184#discussion_r616869662
##########
File path: hbase-shaded/pom.xml
##########
@@ -553,6 +553,13 @@
<exclude>keytab.txt</exclude>
</excludes>
</filter>
+ <filter>
+ <!-- Remove the shaded guava added in hadoop-3.3.1+-->
+ <artifact>*:*</artifact>
Review comment:
@ndimiduk its not jars, its excluding classes.
I tried doing
+ <!-- Don't include the shaded guava jar
added in hadoop-3.3.1+-->
+
<artifact>org.apache.hadoop.thirdparty:hadoop-shaded-guava</artifact>
... this don't work... shaded classes sneak through. Let me push a noop
change on a few of the modules to trip unit test runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
