nyl3532016 commented on a change in pull request #3179: URL: https://github.com/apache/hbase/pull/3179#discussion_r617993063
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/AbstractServer.java ########## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase; + +import java.io.IOException; +import java.lang.reflect.Constructor; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.net.InetSocketAddress; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.client.AsyncClusterConnection; +import org.apache.hadoop.hbase.client.ClusterConnectionFactory; +import org.apache.hadoop.hbase.client.Connection; +import org.apache.hadoop.hbase.ipc.RpcClient; +import org.apache.hadoop.hbase.ipc.ServerNotRunningYetException; +import org.apache.hadoop.hbase.master.HMaster; +import org.apache.hadoop.hbase.master.MasterRpcServicesVersionWrapper; +import org.apache.hadoop.hbase.regionserver.HRegionServer; +import org.apache.hadoop.hbase.security.Superusers; +import org.apache.hadoop.hbase.security.User; +import org.apache.hadoop.hbase.security.UserProvider; +import org.apache.hadoop.hbase.util.Sleeper; +import org.apache.hadoop.hbase.zookeeper.ClusterStatusTracker; +import org.apache.hadoop.hbase.zookeeper.MasterAddressTracker; +import org.apache.hadoop.hbase.zookeeper.ZKClusterId; +import org.apache.hadoop.hbase.zookeeper.ZKWatcher; +import org.apache.hadoop.ipc.RemoteException; +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.zookeeper.KeeperException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hbase.thirdparty.com.google.protobuf.BlockingRpcChannel; + +import org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos; + +@InterfaceAudience.Private +public abstract class AbstractServer extends Thread implements Server { + private static final Logger LOG = LoggerFactory.getLogger(AbstractServer.class); + protected Configuration conf; + // A sleeper that sleeps for msgInterval. + protected Sleeper sleeper; + protected int msgInterval; + /** + * This servers startcode. + */ + protected long startcode; + /** + * Unique identifier for the cluster we are a part of. + */ + protected String clusterId; + protected UserProvider userProvider; + protected int shortOperationTimeout; + // zookeeper connection and watcher + protected ZKWatcher zooKeeper; + /** + * The asynchronous cluster connection to be shared by services. + */ + protected AsyncClusterConnection asyncClusterConnection; + + /** + * The server name the Master sees us as. Its made from the hostname the master passes us, port, + * and server startcode. Gets set after registration against Master. + */ + private ServerName serverName; + /** + * True if this RegionServer is coming up in a cluster where there is no Master; means it needs to + * just come up and make do without a Master to talk to: e.g. in test or HRegionServer is doing + * other than its usual duties: e.g. as an hollowed-out host whose only purpose is as a + * Replication-stream sink; see HBASE-18846 for more. TODO: can this replace + * {@link org.apache.hadoop.hbase.regionserver.HRegionServer#TEST_SKIP_REPORTING_TRANSITION} ? + */ + protected final boolean masterless; + private static final String MASTERLESS_CONFIG_NAME = "hbase.masterless"; + + // RPC client. Used to make the stub above that does region server status checking. + protected RpcClient rpcClient; + + // Set when a report to the master comes back with a message asking us to + // shutdown. Also set by call to stop when debugging or running unit tests + // of AbstractServer in isolation. + protected volatile boolean stopped = false; + + // master address tracker + protected MasterAddressTracker masterAddressTracker; + // Cluster Status Tracker + protected ClusterStatusTracker clusterStatusTracker; + /** + * Setup our cluster connection if not already initialized. + */ + protected final synchronized void setupClusterConnection() throws IOException { + if (asyncClusterConnection == null) { + Configuration conf = cleanupConfiguration(); + InetSocketAddress localAddress = new InetSocketAddress(getRpcService().isa.getAddress(), 0); + User user = userProvider.getCurrent(); + asyncClusterConnection = + ClusterConnectionFactory.createAsyncClusterConnection(conf, localAddress, user); + } + } + + @Override + public ServerName getServerName() { + return this.serverName; + } + + public void setServerName(ServerName serverName) { + this.serverName = serverName; + } + + public int getMsgInterval() { + return msgInterval; + } + + public String getClusterId() { + return this.clusterId; + } + + /** + * Bring up connection to zk ensemble and then wait until a master for this cluster and then after + * that, wait until cluster 'up' flag has been set. This is the order in which master does things. + * <p> + * Finally open long-living server short-circuit connection. + */ + @edu.umd.cs.findbugs.annotations.SuppressWarnings(value = "RV_RETURN_VALUE_IGNORED_BAD_PRACTICE", + justification = "cluster Id znode read would give us correct response") + protected void initializeZooKeeper() throws IOException, InterruptedException { + // Nothing to do in here if no Master in the mix. + if (this.masterless) { + return; + } + // If we are HMaster then the cluster id should have already been set. + if (clusterId == null) { + try { + clusterId = ZKClusterId.readClusterIdZNode(this.zooKeeper); + if (clusterId == null) { + this.abort("Cluster ID has not been set"); + } + LOG.info("ClusterId : " + clusterId); + } catch (KeeperException e) { + this.abort("Failed to retrieve Cluster ID", e); + } + } + } + + protected AbstractServer(final Configuration conf, String processName) throws IOException { + super(processName); // thread name + this.startcode = System.currentTimeMillis(); + this.conf = conf; + this.masterless = conf.getBoolean(MASTERLESS_CONFIG_NAME, false); + this.userProvider = UserProvider.instantiate(conf); + this.shortOperationTimeout = conf.getInt(HConstants.HBASE_RPC_SHORTOPERATION_TIMEOUT_KEY, + HConstants.DEFAULT_HBASE_RPC_SHORTOPERATION_TIMEOUT); + Superusers.initialize(conf); + } + + @Override + public Connection getConnection() { + return getAsyncConnection().toConnection(); + } + + @Override + public Connection createConnection(Configuration conf) throws IOException { + return null; Review comment: should not, I will fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
