ZhaoBQ commented on a change in pull request #3139:
URL: https://github.com/apache/hbase/pull/3139#discussion_r623735082
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##########
@@ -101,11 +106,21 @@ public void onConfigurationChange(Configuration conf) {
setConf(conf);
}
- private static int parseMinRegionCount(final Configuration conf) {
- final int parsedValue = conf.getInt(MIN_REGION_COUNT_KEY,
DEFAULT_MIN_REGION_COUNT);
+ private static int parseMergeMinRegionCount(final Configuration conf) {
+ String parsedStringValue = conf.get(MERGE_MIN_REGION_COUNT_KEY);
Review comment:
And I found after conf.addDeprecation(deprecatedConf, newConf), the
conf.get(deprecatedConf) can not get value even we configured in conf file. So
if the configuration is not modified before upgrade to HBase-2.5, then the
configuration will be use default value. I don't know if i express cleared...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
