virajjasani commented on a change in pull request #3213:
URL: https://github.com/apache/hbase/pull/3213#discussion_r624646868
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestSyncReplicationStandbyKillRS.java
##########
@@ -72,16 +72,26 @@ public void testStandbyKillRegionServer() throws Exception {
Thread t = new Thread(() -> {
try {
List<JVMClusterUtil.RegionServerThread> regionServers =
- UTIL2.getMiniHBaseCluster().getLiveRegionServerThreads();
+ UTIL2.getMiniHBaseCluster().getLiveRegionServerThreads();
+ LOG.debug("Going to stop {} RSes: [{}]",
+ regionServers.stream().map(rst ->
rst.getRegionServer().getServerName().getServerName())
+ .collect(Collectors.joining(", ")));
for (JVMClusterUtil.RegionServerThread rst : regionServers) {
ServerName serverName = rst.getRegionServer().getServerName();
- LOG.debug("Going to stop [{}]", serverName);
+ LOG.debug("Going to RS stop [{}]", serverName);
rst.getRegionServer().stop("Stop RS for test");
waitForRSShutdownToStartAndFinish(activeMaster, serverName);
+ LOG.debug("Going to start a new RS");
JVMClusterUtil.RegionServerThread restarted =
- UTIL2.getMiniHBaseCluster().startRegionServer();
+ UTIL2.getMiniHBaseCluster().startRegionServer();
+ LOG.debug("Waiting RS [{}] to online",
restarted.getRegionServer().getServerName());
restarted.waitForServerOnline();
+ LOG.debug("Waiting the old RS {} thread to quit", rst.getName());
+ rst.join();
Review comment:
Nice
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestSyncReplicationStandbyKillRS.java
##########
@@ -72,16 +72,26 @@ public void testStandbyKillRegionServer() throws Exception {
Thread t = new Thread(() -> {
try {
List<JVMClusterUtil.RegionServerThread> regionServers =
- UTIL2.getMiniHBaseCluster().getLiveRegionServerThreads();
+ UTIL2.getMiniHBaseCluster().getLiveRegionServerThreads();
+ LOG.debug("Going to stop {} RSes: [{}]",
+ regionServers.stream().map(rst ->
rst.getRegionServer().getServerName().getServerName())
+ .collect(Collectors.joining(", ")));
Review comment:
No of placeholders (2) are not matching no of actual arguments (1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
