anoopsjohn commented on a change in pull request #3215:
URL: https://github.com/apache/hbase/pull/3215#discussion_r624854957
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java
##########
@@ -196,13 +202,17 @@ public void cacheBlock(BlockCacheKey key, Cacheable
value) {
key.getHfileName(), key.getOffset(), value.heapSize(),
DEFAULT_MAX_BLOCK_SIZE));
}
} else {
+ value.retain();
Review comment:
We might have to have a closer look here. Because now the reads from FS
may be to shared buffers, we will have to close here. See the LRU cache. I
will also do a detailed read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
