Apache9 commented on a change in pull request #3220:
URL: https://github.com/apache/hbase/pull/3220#discussion_r625054328
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java
##########
@@ -230,6 +230,8 @@ private void waitForRSShutdownToStartAndFinish(MasterThread
activeMaster,
}
log("Server [" + serverName + "] marked as dead, waiting for it to " +
"finish dead processing");
+ // wait SCP be executed
+ Thread.sleep(100);
Review comment:
We'd better not add unconditional sleeps in code. Is it possible to test
whether SCP has been executed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
