ndimiduk commented on a change in pull request #3139:
URL: https://github.com/apache/hbase/pull/3139#discussion_r625251956
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##########
@@ -101,11 +106,21 @@ public void onConfigurationChange(Configuration conf) {
setConf(conf);
}
- private static int parseMinRegionCount(final Configuration conf) {
- final int parsedValue = conf.getInt(MIN_REGION_COUNT_KEY,
DEFAULT_MIN_REGION_COUNT);
+ private static int parseMergeMinRegionCount(final Configuration conf) {
+ String parsedStringValue = conf.get(MERGE_MIN_REGION_COUNT_KEY);
Review comment:
The example of the use of conf deprecation from block cache that you
mention on Jira is, in my opinion, an example that should not be followed.
> And I found after conf.addDeprecation(deprecatedConf, newConf), the
conf.get(deprecatedConf) can not get value even we configured in conf file. So
if the configuration is not modified before upgrade to HBase-2.5, then the
configuration will be use default value.
Okay, this is bad.
##########
File path: hbase-common/src/main/resources/hbase-default.xml
##########
@@ -638,12 +638,6 @@ possible configurations would overwhelm and obscure the
important.
<value>true</value>
<description>Whether to merge a region as part of
normalization.</description>
</property>
- <property>
- <name>hbase.normalizer.min.region.count</name>
Review comment:
I don't understand the backward compatibility concern here, can you
explain again for me? The variable `MERGE_MIN_REGION_COUNT_KEY` is not public,
just like `MIN_REGION_COUNT_KEY`, so users won't use the variables in their
code. The configuration key `"hbase.normalizer.merge.min.region.count"` is new
with this patch, so if a user was looking up that value in an existing release,
it should error or return no value. We don't need to preserve backward
compatibility of a configuration key that is not defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
