[
https://issues.apache.org/jira/browse/HBASE-25847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339373#comment-17339373
]
Andrew Kyle Purtell edited comment on HBASE-25847 at 5/5/21, 2:24 AM:
----------------------------------------------------------------------
Mostly just logging, but this is also a real bugfix:
{code:java}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
index 4167e3745e..93e4731aed 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
@@ -223,7 +223,7 @@ public class HbckChore extends ScheduledChore {
.isTableState(regionInfo.getTable(), TableState.State.DISABLED)) {
disabledTableRegions.add(regionInfo.getRegionNameAsString());
}
- if (regionInfo.isSplitParent()) {
+ if (regionState.isSplit()) {
splitParentRegions.add(regionInfo.getRegionNameAsString());
}
HbckRegionInfo.MetaEntry metaEntry =
{code}
Otherwise splitParentRegions isn't properly populated.
was (Author: apurtell):
Mostly just logging, but this is also a real minor bugfix:
{code:java}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
index 4167e3745e..93e4731aed 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
@@ -223,7 +223,7 @@ public class HbckChore extends ScheduledChore {
.isTableState(regionInfo.getTable(), TableState.State.DISABLED)) {
disabledTableRegions.add(regionInfo.getRegionNameAsString());
}
- if (regionInfo.isSplitParent()) {
+ if (regionState.isSplit()) {
splitParentRegions.add(regionInfo.getRegionNameAsString());
}
HbckRegionInfo.MetaEntry metaEntry =
{code}
With current code it doesn't hurt that splitParentRegions isn't properly
populated, but in the future it might be an issue.
> More DEBUG and TRACE level logging in CatalogJanitor and HbckChore
> ------------------------------------------------------------------
>
> Key: HBASE-25847
> URL: https://issues.apache.org/jira/browse/HBASE-25847
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.4.3
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3
>
>
> Add DEBUG and TRACE level logging to CatalogJanitor and HbckChore to
> facilitate debugging and verification of correct operation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
