apurtell commented on a change in pull request #3230:
URL: https://github.com/apache/hbase/pull/3230#discussion_r626219664
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java
##########
@@ -317,11 +329,19 @@ static boolean cleanParent(MasterServices services,
RegionInfo parent, Result ro
LOG.debug("Deleting region " + parent.getShortNameToLog() + " because
daughters -- " +
daughterA + ", " + daughterB + " -- no longer hold references");
ProcedureExecutor<MasterProcedureEnv> pe =
services.getMasterProcedureExecutor();
- pe.submitProcedure(new GCRegionProcedure(pe.getEnvironment(), parent));
- // Remove from in-memory states
Review comment:
GCRegionProcedure does this. It is not needed here too. I think it
better to let the procedure do it. We expect the procedure to take care of such
details, so let's in fact do that.
Keeping this code around would be harmless, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
