[
https://issues.apache.org/jira/browse/HBASE-25854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25854:
----------------------------------------
Description:
In CatalogJanitor we schedule GCRegionProcedure to clean up both filesystem and
in-memory state after a split, and GCMultipleMergedRegionsProcedure to do the
same for merges.
Both GCRegionProcedure and GCMultipleMergedRegionsProcedure clean up in-memory
state, but CatalogJanitor also does this redundantly just after scheduling the
procedures.
The cleanup should be done in only one place. Presumably we are using the
procedures to do it in a principled way. This is least a nit, but probably a
source of future bugs. Remove the redundancy in CatalogJanitor and fix any
follow on issues, like test failures.
was:
In CatalogJanitor we schedule GCRegionProcedure to clean up both filesystem and
in-memory state after a split, and GCMultipleMergedRegionsProcedure to do the
same for merges.
Both GCRegionProcedure and GCMultipleMergedRegionsProcedure clean up in-memory
state, but CatalogJanitor also does this redundantly just after scheduling the
procedures.
The cleanup should be done in only one place. Presumably we are using the
procedures to do it in a principled way. Remove the redundancy in
CatalogJanitor (and fix any follow on issues, like test failures).
> Remove redundant AM in-memory state changes in CatalogJanitor
> -------------------------------------------------------------
>
> Key: HBASE-25854
> URL: https://issues.apache.org/jira/browse/HBASE-25854
> Project: HBase
> Issue Type: Sub-task
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3
>
>
> In CatalogJanitor we schedule GCRegionProcedure to clean up both filesystem
> and in-memory state after a split, and GCMultipleMergedRegionsProcedure to do
> the same for merges.
> Both GCRegionProcedure and GCMultipleMergedRegionsProcedure clean up
> in-memory state, but CatalogJanitor also does this redundantly just after
> scheduling the procedures.
> The cleanup should be done in only one place. Presumably we are using the
> procedures to do it in a principled way. This is least a nit, but probably a
> source of future bugs. Remove the redundancy in CatalogJanitor and fix any
> follow on issues, like test failures.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
