bharathv commented on a change in pull request #3230:
URL: https://github.com/apache/hbase/pull/3230#discussion_r626763927
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java
##########
@@ -165,13 +168,19 @@ public int scan() throws IOException {
this.lastReport = scanForReport();
if (!this.lastReport.isEmpty()) {
LOG.warn(this.lastReport.toString());
+ } else {
+ LOG.debug(this.lastReport.toString());
Review comment:
nit: toString() might be an expensive call if debug is not enabled,
might want to switch to a isDebugEnabled() guard, (later versions of log4j
supports log.debug(Object)/log.debug(Supplier) so that toString() is eventually
evaluated after the debug guard check)..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
