Apache9 commented on a change in pull request #3233:
URL: https://github.com/apache/hbase/pull/3233#discussion_r627141725
##########
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
##########
@@ -100,9 +99,11 @@ protected BaseLoadBalancer(MetricsBalancer metricsBalancer)
{
this.metricsBalancer = (metricsBalancer != null) ? metricsBalancer : new
MetricsBalancer();
}
- @Override
- public void setConf(Configuration conf) {
- this.config = conf;
+ protected final Configuration getConf() {
+ return provider.getConfiguration();
+ }
+
+ protected void setConf(Configuration conf) {
Review comment:
There is another call path, from
ConfigurationObserver.onConfigurationChange, so here we need to keep this
method as is.
Filed HBASE-25852 for moving the intialization work all to initialize
method, which could make the implementation more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
