[ 
https://issues.apache.org/jira/browse/HBASE-25851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-25851.
-------------------------------
    Hadoop Flags: Reviewed
      Resolution: Fixed

Pushed to master and branch-2.

Thanks [~niuyulin] for reviewing.

> Make LoadBalancer not extend Configurable interface
> ---------------------------------------------------
>
>                 Key: HBASE-25851
>                 URL: https://issues.apache.org/jira/browse/HBASE-25851
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Balancer
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> On master, LoadBalancer has a setClusterInfoProvider method and on branch-2, 
> LoadBalancer has a setMasterServices method. Both ClusterInfoProvider and 
> MasterServices could give a Configuration out so I do not think we need to 
> expose another setConf method.
> When refactoring StochasticLoadBalancer, the initialization order is also a 
> pain as after setConf, we will load a lot of configuration but at that time, 
> the ClusterInfoProvider is not present, and easy to cause NPE...
> And it could also help simplity locking.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to