ndimiduk commented on pull request #3139:
URL: https://github.com/apache/hbase/pull/3139#issuecomment-833926085
> So do we need to create another issue to correct this wrong usage first?
First or in addition to, I think is up to you. It looks like you've
identified an issue in our usage of this Hadoop API, and have worked out a
testing strategy -- this is great! I find 10 usages of `addDeprecation` on a
recent checkout of master. If you'd like to pursue this cleanup, and can add
explicit test coverage that we're preserving these configurations correctly, I
think it'd be great! I don't know how we might prevent future miss-use of this
API going forward...
```
$ find . -iname '*.java' -exec grep -iIn 'addDeprecation' {} \+
./hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java:62:
Configuration.addDeprecation(RS_HOSTNAME_KEY, UNSAFE_RS_HOSTNAME_KEY);
./hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java:104:
Configuration.addDeprecation(DEPRECATED_ALLOCATOR_POOL_ENABLED_KEY,
ALLOCATOR_POOL_ENABLED_KEY);
./hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java:105:
Configuration.addDeprecation(DEPRECATED_MAX_BUFFER_COUNT_KEY,
MAX_BUFFER_COUNT_KEY);
./hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java:106:
Configuration.addDeprecation(DEPRECATED_BUFFER_SIZE_KEY, BUFFER_SIZE_KEY);
./hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheFactory.java:101:
Configuration.addDeprecation(DEPRECATED_BLOCKCACHE_BLOCKSIZE_KEY,
BLOCKCACHE_BLOCKSIZE_KEY);
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:493:
Configuration.addDeprecation(RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY,
UNSAFE_RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY);
./hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:69:
Configuration.addDeprecation(MobConstants.DEPRECATED_MOB_CLEANER_PERIOD,
./hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java:88:
Configuration.addDeprecation("hlog.bulk.output", BULK_OUTPUT_CONF_KEY);
./hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java:89:
Configuration.addDeprecation("hlog.input.tables", TABLES_KEY);
./hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java:90:
Configuration.addDeprecation("hlog.input.tablesmap", TABLE_MAP_KEY);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
